-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pass extra includes; configure this with flags #493
base: main
Are you sure you want to change the base?
Conversation
This sounds like asking developers to add the include directories of the standard library on a regular project. I'm not sure that would be convenient for regular users. On the other hand, I totally understand the issue for packaging xeus-cling; I think a conditional compilation could help here, but maybe @SylvainCorlay has a better idea? By the way, if you remove the extra arg, you can also remove the extra |
Not quite, as it's still changing the process name in the 0th argument.
Do regular users actually invoke Also, which standard library do you mean? In my experience of packaging It wasn't clear to me what the purpose of this extra argument was, as it doesn't come with a flag before it such as |
Pardon my brevity as I am commenting from my phone. I think it would be fine to remove this and pass the command line argument from the kernelspec. @thomasjm, this is specified in the kernel.json.in file in this repository. |
@thomasjm here is such a kernel spec file: https://github.com/jupyter-xeus/xeus-cling/blob/main/share/jupyter/kernels/xcpp14/kernel.json.in |
Thanks! I just tried this in the latest commit. I haven't tested it yet, had a little trouble using |
I don't think we actually define LLVM_DIR as a cmake variable. |
Okay, how about using Line 98 in 471b1b6
Incidentally, the variable called |
Okay, I was able to get a Conda environment running on a normal Ubuntu machine and test this out. With the latest commit it seems to work! |
This fixes an issue that came up when working on Nixpkgs packaging for
xeus-cling
here.It's weird for
xeus-cling
to stick extra arguments on to pass to the interpreter when it already passes the user-provided ones from the command line. The user is perfectly capable of adding this LLVM include directory if desired.